Add optional previous & timestamps flags to log requests
#35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the optional boolean arguments
previousandtimestampsto thelogs()method and the optional boolean argumenttimestampsto thefollow()method, to be able to request a pod's previously terminated container from the API and to be able to toggle timestamps on the log responses and streams on and off.I've initialized all arguments as false to be able to just ignore them without breaking backwards compatibility. Please let me know if this makes sense to you the way it's implemented or if you'd prefer it differently.
And again, thanks for all the effort you're putting into this project! 🙂